don't set autoresizing mask on ios as that's not supported #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
added
the
PR: needs back-porting
|
great find, thank you! |
madsmtm
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Ah damn, I think I relied on testing on Mac Catalyst a little bit too much, and then only tested previous iterations (but not the final PR) in the simulator - sorry!
@madsmtm do you think we need to do something else on iOS instead?
The details are a bit out of my cache here, but yes, we should be doing something different on iOS - but that's what #6210 is for.
In total, with #6107 and this PR, we're not worse off regarding resizing on iOS (it didn't work before). So 👍 from me.
Co-authored-by: Mads Marquart <[email protected]>
Wumpf
approved these changes
Nov 15, 2024
|
Backported to v23 here without PR 78fbdfc |
Wumpf
removed
the
PR: needs back-porting
Wumpf
pushed a commit
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
bevyengine/bevy#16363
Description
After updating to wgpu 23, Bevy crashes on iOS with
fatal runtime error: Rust cannot catch foreign exceptionsThis started with #6107
By adding logging between all lines of code in the
get_metal_layer, it came fromwgpu/wgpu-hal/src/metal/surface.rs
Line 226 in ae6c6fb
new_layer is a
CAMetalLayerwhich is available on iOS https://developer.apple.com/documentation/quartzcore/cametallayerbut
autoresizingMaskis only available on macOS https://developer.apple.com/documentation/quartzcore/calayer/1410877-autoresizingmaskthis PR stops setting the
autoresizingMaskon iOSTesting
I tested the same fix on the 23 tag with Bevy and it works
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.